stdenv: MACOSX_DEPLOYMENT_TARGET 10.10 -> 10.12 #64458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging - this is needed for #64255 |
matthewbauer
approved these changes
Jul 8, 2019
matthewbauer
reviewed
Jul 8, 2019
| @@ -32,7 +32,7 @@ in rec { | |||
| export NIX_ENFORCE_NO_NATIVE="''${NIX_ENFORCE_NO_NATIVE-1}" | |||
| export NIX_IGNORE_LD_THROUGH_GCC=1 | |||
| stripAllFlags=" " # the Darwin "strip" command doesn't know "-s" | |||
| export MACOSX_DEPLOYMENT_TARGET=10.10 | |||
| export MACOSX_DEPLOYMENT_TARGET=10.12 | |||
| export SDKROOT= | |||
| export CMAKE_OSX_ARCHITECTURES=x86_64 | |||
There was a problem hiding this comment.
I believe this is a no-op. CMAKE_OSX_ARCHITECTURES should be in cmakeFlags, not an env var. I believe this can be removed.
There was a problem hiding this comment.
gl_cv_func_getcwd_abort_bug can be removed as well
ofborg
bot
added
6.topic: darwin
|
bump The logs are no longer available, I take it? What can I do (including debugging) to get this merged? |
This was referenced Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)