Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.opencv: remove #64430

Merged
merged 1 commit into from Jul 8, 2019
Merged

python37Packages.opencv: remove #64430

merged 1 commit into from Jul 8, 2019

Conversation

OmnipotentEntity
Copy link
Contributor

As far as I can tell after a few days of searching, OpenCV's version 2 does not at all support Python version 3, and other distributions of Python bindings for OpenCV v2.4.x that I could find do not support Python3 for this version series.

(By not support I mean it doesn't work.)

Reference issue: #64363

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OmnipotentEntity
python37Packages.opencv: remove
3ba59bd 
As far as I can tell after a few days of searching, OpenCV's version 2
does not at all support Python version 3, and other distributions of
Python bindings for OpenCV v2.4.x that I could find do not support
Python3 for this version series.
matthiasbeyer
matthiasbeyer approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good.

@FRidh FRidh merged commit f566583 into NixOS:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OmnipotentEntity @matthiasbeyer @FRidh