Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taglib: fix ogg file corruption #68088

Merged
merged 1 commit into from Sep 7, 2019
Merged

taglib: fix ogg file corruption #68088

merged 1 commit into from Sep 7, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

taglib hasn't had a release for ages, but the most recent release 1.11.1 has a nasty file corruption bug triggered by writing a tag to an ogg file thereby breaking it completely.

Several pieces of software do basic version tests to see if they should use the system-provided taglib or their own vendored version due to this bug.

This just fixes the corruption bug (a one-liner) - the consumers of the library need to be told to not use the vendored version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Profpatsch
Copy link
Member

@GrahamcOfBorg build taglib

@zimbatm zimbatm merged commit 27f1086 into NixOS:staging Sep 7, 2019
@peterhoeg peterhoeg deleted the f/taglib branch September 8, 2019 07:14
@peterhoeg peterhoeg restored the f/taglib branch September 9, 2019 00:24
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants