Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upower: 0.99.10 -> 0.99.11 #68037

Merged
merged 5 commits into from Sep 8, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 3, 2019

Motivation for this change

https://gitlab.freedesktop.org/upower/upower/-/tags/UPOWER_0_99_11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 7, 2019

Could you move the following to nativeBuildInputs:

intltool
libxslt
docbook_xsl
gobject-introspection

and replace intltool by gettext as suggested in the news?

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 8, 2019

@jtojnar Did that and then some 👍

@jtojnar
Copy link
Contributor

jtojnar commented Sep 8, 2019

Given that we hard depend on libgudev, which is glib wrapper around udev, which is part of systemd, useSystemd = false does not make sense anymore.

@worldofpeace
Copy link
Contributor

Given that we hard depend on libgudev, which is glib wrapper around udev, which is part of systemd, useSystemd = false does not make sense anymore.

It seems that polkit and pulseaudio have a useSystemd as well. Wonder if the situation is similar to this one.

* correct inputs
* drop dbus-glib
  Has not been needed for a very long
  time.
* intltool -> gettext
* add optional libimobiledevice
* propagate glib
  It's in Requires
* dev output
* drop useSystemd
All of these changes ++ are in the upstream unit
Also drop glib in path of unit as I don't believe
this should be needed anymore.
Introduced 7 years ago, it's likely the issue has
been fixed. Even possible this could cause issues
with recent upower.
@worldofpeace worldofpeace merged commit 362c2f6 into NixOS:master Sep 8, 2019
@dtzWill dtzWill deleted the update/upower-0.99.11 branch September 9, 2019 23:35
@dtzWill
Copy link
Member Author

dtzWill commented Sep 9, 2019

@worldofpeace 😍 thanks, this is great! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants