Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php73: 7.3.8 -> 7.3.9 (security) #68038

Merged
merged 1 commit into from Sep 7, 2019
Merged

php73: 7.3.8 -> 7.3.9 (security) #68038

merged 1 commit into from Sep 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 3, 2019

Motivation for this change

https://www.php.net/archive/2019.php#2019-08-29-1

https://www.php.net/ChangeLog-7.php#7.3.9

We should probably bump other versions we package, released
concurrently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from etu and globin September 4, 2019 00:06
@etu etu added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 4, 2019
@etu
Copy link
Contributor

etu commented Sep 4, 2019

Yes, we should update the older minor-versions as well to their respective patch updates as well as backporting it all to stable

@etu etu merged commit 735e3d1 into NixOS:master Sep 7, 2019
@etu etu mentioned this pull request Sep 7, 2019
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @etu @andir @TredwellGit