Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.labelbox: init at 2.1 #68097

Merged
merged 1 commit into from Oct 31, 2019
Merged

pythonPackages.labelbox: init at 2.1 #68097

merged 1 commit into from Oct 31, 2019

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Sep 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @CMCDragonkai

@Rakesh4G Rakesh4G requested a review from FRidh as a code owner September 4, 2019 09:45
@mmahut
Copy link
Member

mmahut commented Sep 4, 2019

@GrahamcOfBorg build pythonPackages.labelbox python3Packages.labelbox

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Sep 5, 2019

@jonringer , Thanks i will test the suggested changes and update accordingly.

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Sep 5, 2019

@jonringer , I have updated the suggested changes and tested.

@GrahamcOfBorg build pythonPackages.labelbox python3Packages.labelbox

@jonringer
Copy link
Contributor

you need to be whitelisted for ofborg to pick up commands

@GrahamcOfBorg build pythonPackages.labelbox python3Packages.labelbox

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Sep 6, 2019

you need to be whitelisted for ofborg to pick up commands

@GrahamcOfBorg build pythonPackages.labelbox python3Packages.labelbox

OK @jonringer , Thanks.

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@jonringer
Copy link
Contributor

I noticed that there were no tests ran, it appears that the pypi package doesn't include tests. I would pull source from https://github.com/Labelbox/labelbox-python so that tests are ran (this will help to know if the package is broken by one of it's dependencies being updated)

@Rakesh4G
Copy link
Contributor Author

I noticed that there were no tests ran, it appears that the pypi package doesn't include tests. I would pull source from https://github.com/Labelbox/labelbox-python so that tests are ran (this will help to know if the package is broken by one of it's dependencies being updated)

OK @jonringer . I will update this.

@Rakesh4G
Copy link
Contributor Author

I noticed that there were no tests ran, it appears that the pypi package doesn't include tests. I would pull source from https://github.com/Labelbox/labelbox-python so that tests are ran (this will help to know if the package is broken by one of it's dependencies being updated)

Hi @jonringer , I had tried to take source from https://github.com/Labelbox/labelbox-python

  • release source on GitHub is showing version 0.0.2 (9 Sep 2018) . On https://pypi.org labelbox 2.0.1 (3 Sep 2019) is available. Also
  • when i tried to build labelbox-python from GitHub it used pipenv and is causing access related issues. not sure how to proceed on this.

Traceback (most recent call last): File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/bin/.pipenv-wrapped", line 11, in <module> sys.exit(cli()) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 764, in __call__ return self.main(*args, **kwargs) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 717, in main rv = self.invoke(ctx) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 1137, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 956, in invoke return ctx.invoke(self.callback, **ctx.params) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/decorators.py", line 64, in new_func return ctx.invoke(f, obj, *args, **kwargs) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/cli/command.py", line 408, in run command=command, args=args, three=state.three, python=state.python, pypi_mirror=state.pypi_mirror File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/core.py", line 2310, in do_run three=three, python=python, validate=False, pypi_mirror=pypi_mirror, File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/core.py", line 574, in ensure_project pypi_mirror=pypi_mirror, File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/core.py", line 489, in ensure_virtualenv if not project.virtualenv_exists: File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/project.py", line 272, in virtualenv_exists if self.pipfile_exists and os.path.exists(self.virtualenv_location): File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/project.py", line 437, in virtualenv_location self._virtualenv_location = self.get_location_for_virtualenv() File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/project.py", line 294, in get_location_for_virtualenv return str(get_workon_home().joinpath(self.virtualenv_name)) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/utils.py", line 1414, in get_workon_home mkdir_p(str(expanded_path)) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/utils.py", line 864, in mkdir_p mkdir_p(head) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/utils.py", line 864, in mkdir_p mkdir_p(head) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/utils.py", line 864, in mkdir_p mkdir_p(head) File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/utils.py", line 869, in mkdir_p os.mkdir(newdir) PermissionError: [Errno 13] Permission denied: '/homeless-shelter'

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Sep 11, 2019 via email

@jonringer
Copy link
Contributor

release source on GitHub is showing version 0.0.2 (9 Sep 2018) . On https://pypi.org labelbox 2.0.1 (3 Sep 2019) is available.

interesting... I wonder how they are doing releases then...

when i tried to build labelbox-python from GitHub it used pipenv and is causing access related issues. not sure how to proceed on this

So, $HOME is usually set to "/homeless-shelter", and this is intentional so that the builds aren't leaking into the system. generally I do HOME=$TMPDIR for things like tests, but for builds im not sure what the right answer is, as it may need some of those artifacts later. I also don't have much experience with pipenv builds.

@Rakesh4G
Copy link
Contributor Author

I think you can use the master branch with a fixed commit.

Permission related error is still there on my system.

File "/nix/store/m7kvd3qg2dwl6kzp583f6bdc16d2hpps-pipenv-2018.11.26/lib/python3.7/site-packages/pipenv/utils.py", line 869, in mkdir_p os.mkdir(newdir) PermissionError: [Errno 13] Permission denied: '/homeless-shelter' builder for '/nix/store/hcgf2bi6pyaj3giz9isxwjnin003agbf-labelbox-python-0.0.2.drv' failed with exit code 1

@Rakesh4G
Copy link
Contributor Author

@CMCDragonkai @jonringer
Finally i managed to build labelbox-python from master of
https://github.com/Labelbox/labelbox-python

I had to disable pytest for now. I am getting this error when trying to run pytest, which i understand is not passing correct arguments to pytest.

running install tests ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...] pytest: error: unrecognized arguments: --cov-report --cov-report term --cov=labelbox inifile: /build/labelbox-python-f55ba70/setup.cfg rootdir: /build/labelbox-python-f55ba70
Some inputs are present at : https://github.com/Labelbox/labelbox-python/blob/master/setup.cfg#L62

@CMCDragonkai
Copy link
Member

If everything works, at the end make sure to squash all commits into 1 commit following the commit guidelines for nixpkgs.

@Rakesh4G Rakesh4G changed the title pythonPackages.labelbox: init at 2.0.1 pythonPackages.labelbox: init at 2.1 Sep 30, 2019
@Rakesh4G
Copy link
Contributor Author

If everything works, at the end make sure to squash all commits into 1 commit following the commit guidelines for nixpkgs.

Hi @CMCDragonkai , I have squashed all commits into 1 commit. I think this is now ready for merge from my side. Thanks.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Oct 30, 2019 via email

@jonringer
Copy link
Contributor

which one is able to be merged, I'll merge fist

@Rakesh4G
Copy link
Contributor Author

which one is able to be merged, I'll merge fist
Hi @jonringer ,
#67760 is good to go first.

@jonringer
Copy link
Contributor

please remove maintainers commit :)

@Rakesh4G
Copy link
Contributor Author

please remove maintainers commit :)

OK, Thanks.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.labelbox python37Packages.labelbox python38Packages.labelbox

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
outputs LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68097
3 package were build:
python27Packages.labelbox python37Packages.labelbox python38Packages.labelbox

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68097
3 package were build:
python27Packages.labelbox python37Packages.labelbox python38Packages.labelbox

@jonringer jonringer merged commit 6b46338 into NixOS:master Oct 31, 2019
@Rakesh4G Rakesh4G deleted the labelbox branch December 10, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMCDragonkai CMCDragonkai CMCDragonkai left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rakesh4G @mmahut @jonringer @CMCDragonkai @lheckemann