xbps: 0.56 -> 0.57 #68060
Merged
xbps: 0.56 -> 0.57 #68060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
jonringer
reviewed
Sep 4, 2019
There was a problem hiding this comment.
fails to build:
builder for '/nix/store/fjmr3qms3kpya339skr1k06aaw1xmyif-xbps-0.57.drv' failed with exit code 2; last 10 log lines:
main.c: In function 'rcv_load_file':
main.c:195:2: error: ignoring return value of 'fread', declared with attribute warn_unused_result [-Werror=unused-result]
(void)fread(rcv->buf, sizeof(char), rcv->len, file);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [../../mk/prog.mk:45: main.o] Error 1
make[2]: Leaving directory '/build/source/bin/xbps-checkvers'
make[1]: *** [../mk/subdir.mk:3: all] Error 1
make[1]: Leaving directory '/build/source/bin'
make: *** [Makefile:15: all] Error 1
cannot build derivation '/nix/store/r5awh43v8d9w02999c4lbgczbywspljh-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 4 copied (0.4 MiB), 0.2 MiB DL]
|
Interesting! Sorry for missing that! Thanks for testing-- I actually only tested this w/musl, which apparently doesn't trigger this. No warn_unused_result attributes in musl's headers, looks like. Will fix in a few, thanks! |
|
@GrahamcOfBorg build xbps pkgsMusl.xbps |
jonringer
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @dtzWill ;)