New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libphonenumber: 8.9.9 -> 8.10.17 #68067
Conversation
Thanks @jonringer! Co-Authored-By: Jon <jonringer@users.noreply.github.com>
19eec07
to
3bae6c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM (some suggestions)
leaf package
[3 built, 15 copied (226.5 MiB), 27.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68067
1 package were build:
libphonenumber
I think the darwin build might work if you did something like:
buildInputs = [...]
++ stdenv.lib.optionals stdenv.isDarwin [ libiconv CoreFoundation ];
seems to not be able to link against corefoundation
@@ -1,17 +1,17 @@ | |||
{ stdenv, fetchFromGitHub, cmake, gmock, boost, pkgconfig, protobuf, icu }: | |||
|
|||
let | |||
version = "8.9.9"; | |||
version = "8.10.17"; | |||
in | |||
stdenv.mkDerivation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.mkDerivation { | |
stdenv.mkDerivation rec { |
in | ||
stdenv.mkDerivation { | ||
name = "phonenumber-${version}"; | ||
pname = "phonenumber"; | ||
inherit version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inherit version; | |
version = "8.10.17"; |
@@ -1,17 +1,17 @@ | |||
{ stdenv, fetchFromGitHub, cmake, gmock, boost, pkgconfig, protobuf, icu }: | |||
|
|||
let | |||
version = "8.9.9"; | |||
version = "8.10.17"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my preference, but I would move the version attr into the derivation
version = "8.10.17"; |
We've got 8.10.20 since ##70496, even with the additional proposed changes. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @