Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdata: 1.16.0 -> 1.17.0 #68048

Merged
merged 1 commit into from Sep 4, 2019
Merged

netdata: 1.16.0 -> 1.17.0 #68048

merged 1 commit into from Sep 4, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 4, 2019

Motivation for this change

Changelog: https://github.com/netdata/netdata/releases/tag/v1.17.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Sep 4, 2019

@GrahamcOfBorg test netdata

jonringer
jonringer approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

Outside the scope of this PR, but the default behavior seems odd

$ ./results/netdata/bin/netdata
2019-09-03 18:12:16: netdata INFO  : MAIN : CONFIG: cannot load user config '/etc/netdata/netdata.conf'. Will try the stock version.
2019-09-03 18:12:16: netdata INFO  : MAIN : CONFIG: cannot load stock config '/nix/store/ill6s9gjjj817vnvvna9c6x6csjpd3kc-netdata-1.17.0/lib/netdata/conf.d/netdata.conf'. Running with internal defaults.
2019-09-03 18:12:16: netdata FATAL : MAIN :Cannot cd to directory '/etc/netdata' # : No such file or directory

2019-09-03 18:12:16: netdata INFO  : MAIN : EXIT: netdata prepares to exit with code 1...
2019-09-03 18:12:16: netdata INFO  : MAIN : EXIT: cleaning up the database...
2019-09-03 18:12:16: netdata INFO  : MAIN : Cleaning up database [0 hosts(s)]...
2019-09-03 18:12:16: netdata INFO  : MAIN : EXIT: all done - netdata is now exiting - bye bye...

@marsam
Copy link
Contributor Author

marsam commented Sep 4, 2019

@jonringer thanks for testing it. netdata usually is executed through the netdata module; but you could also execute it independently passing a custom configuration with -c.

@jonringer
Copy link
Contributor

that's fair, still seems odd it doesn't look in XDG dirs for user config (not sure if that makes sense for this scenario). But if it's just meant to be used through a module (like a daemon), and the module has correct behavior, then I'm not going to hate :)

@marsam marsam merged commit 044cc70 into NixOS:master Sep 4, 2019
@marsam marsam deleted the update-netdata branch September 4, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jonringer