Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ell: 0.21 -> 0.22, iwd: 0.19 -> 0.20, add myself to maintainers #68063

Merged
merged 3 commits into from Sep 14, 2019
Merged

ell: 0.21 -> 0.22, iwd: 0.19 -> 0.20, add myself to maintainers #68063

merged 3 commits into from Sep 14, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92 @dtzWill

@ofborg ofborg bot requested a review from Mic92 September 4, 2019 02:23
@dtzWill
Copy link
Member Author

dtzWill commented Sep 5, 2019

cc @flokli @eliasp (from another iwd PR)

flokli
flokli requested changes Sep 5, 2019
View reviewed changes
pkgs/os-specific/linux/iwd/default.nix Outdated Show resolved Hide resolved
@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
dtzWill and others added 2 commits September 13, 2019 20:59
@dtzWill @worldofpeace
iwd: 0.19 -> 0.20
aaf0ccf 
* don't use deprecated dbus directory
* alphabetize
* drop Mic92 from maintainers
  NixOS#68063 (comment)
* enableParallelBuilding

Co-authored-by: worldofpeace <worldofpeace@protonmail.ch>
@dtzWill @worldofpeace
iwd: revert commit introducing attempt to create /var
208fa6b 
Co-authored-by: worldofpeace <worldofpeace@protonmail.ch>
@worldofpeace
Copy link
Contributor

@dtzWill I might have taken care of those changes for you again 🤣
(Though I do mutually benefit)

Tested with #68147, it's quick.

@worldofpeace worldofpeace merged commit a412701 into NixOS:master Sep 14, 2019
@ofborg ofborg bot requested a review from Mic92 September 14, 2019 01:13
@dtzWill
Copy link
Member Author

dtzWill commented Sep 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @worldofpeace @Mic92 @flokli @lheckemann