Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: 2.60.6 -> 2.60.7 #68052

Merged
merged 1 commit into from Sep 5, 2019
Merged

glib: 2.60.6 -> 2.60.7 #68052

merged 1 commit into from Sep 5, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change

https://gitlab.gnome.org/GNOME/glib/-/tags/2.60.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from lovek323 and 7c6f434c September 4, 2019 01:21
7c6f434c
7c6f434c approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I guess we can only find out if some rev-dependencies are affected by building all of them (Changelog looks like nothing should break)

@dtzWill dtzWill merged commit 8fdb4c2 into NixOS:staging Sep 5, 2019
@dtzWill dtzWill deleted the update/glib-2.60.7 branch September 5, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @7c6f434c