Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vnstat: 2.3 -> 2.4 #68056

Merged
merged 1 commit into from Sep 7, 2019
Merged

vnstat: 2.3 -> 2.4 #68056

merged 1 commit into from Sep 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work
leaf package

[3 built, 3 copied (0.7 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68056
1 package were build:
vnstat

@dtzWill
Copy link
Member Author

dtzWill commented Sep 7, 2019

FWIW, changelog: https://humdi.net/vnstat/CHANGES

Thanks for review, merging after looking through changelog (looks like only fixes problems with 2.3, and unlikely to break existing usage).

@dtzWill dtzWill merged commit c98c1a3 into NixOS:master Sep 7, 2019
@dtzWill dtzWill deleted the update/vnstat-2.4 branch September 7, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @jonringer