Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eksctl: 0.4.3 -> 0.5.0 #68124

Merged
merged 1 commit into from Sep 5, 2019
Merged

eksctl: 0.4.3 -> 0.5.0 #68124

merged 1 commit into from Sep 5, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Sep 5, 2019

Motivation for this change

Update eksctl to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit September 5, 2019 01:51
@mmahut
Copy link
Member

mmahut commented Sep 5, 2019

Build error, please see the checks.

@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 5, 2019

@mmahut Thanks for the review!
It built on aarch64-linux and I could build it successfully on my local NixOS (x86_64).

Let's try to build it again on x86_64-linux.
@GrahamcOfBorg build eksctl

@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 5, 2019

Hi @mmahut, eksctl built successfully on x86_64-linux!
Could you call @GrahamcOfBorg for building eksctl on x86_64-darwin? Thank you!

@mmahut
Copy link
Member

mmahut commented Sep 5, 2019

@GrahamcOfBorg build eksctl

ryantm
ryantm approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • built on NixOS
  • nix-review passed
  • tested basic help messages of all binaries
  • leaf package
  • checked OfBorg all green

@ryantm ryantm merged commit 50f5410 into NixOS:master Sep 5, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 5, 2019

@mmahut @ryantm Thank you!

@xrelkd xrelkd deleted the update/eksctl branch September 5, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @mmahut @ryantm