Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infrastructure/ expectations for Edge classic #18829

Merged
merged 1 commit into from Sep 12, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 4, 2019

We're no longer running this configuration:
#16920

We're no longer running this configuration:
#16920
@gsnedders
Copy link
Member

Do we actually entirely want to remove these, even though we aren't at all regularly running Edge any more? I'd rather have some expectations here as long as we support running against Edge, at least?

@foolip
Copy link
Member Author

foolip commented Sep 4, 2019

I'd rather not have them, they make it more work to update expectations for other browsers if the expectation was shared and now you're not sure if edge_webdriver should change or not, and you can't run it.

@thejohnjansen @mustjab do you have opinions on whether to keep these?

@thejohnjansen
Copy link
Contributor

I don't mind removing them completely because I don't expect us to run WPT.FYI against old Edge. As far as I can tell, the results are not trustworthy anyway because of timeouts and other various issues.

@foolip
Copy link
Member Author

foolip commented Sep 4, 2019

Over to you, @gsnedders :)

@foolip foolip assigned gsnedders and unassigned jgraham Sep 4, 2019
@foolip
Copy link
Member Author

foolip commented Sep 11, 2019

Ping @gsnedders, this will conflict with updates for Safari.

@gsnedders gsnedders merged commit 4d2016d into master Sep 12, 2019
@gsnedders gsnedders deleted the foolip/edge_webdriver_expectations branch September 12, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants