Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setxkbmap: 1.3.1 -> 1.3.2 #68075

Merged
merged 1 commit into from Oct 7, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change

https://lists.x.org/archives/xorg-announce/2019-July/003007.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bjornfor
Copy link
Contributor

Needs rebase.

@dtzWill
Copy link
Member Author

dtzWill commented Sep 15, 2019 via email

@bjornfor
Copy link
Contributor

You've have specified staging as target branch, even though this rebuilds less than 100 packages. Is that correct?

@dtzWill dtzWill changed the base branch from staging to master October 7, 2019 23:14
@dtzWill
Copy link
Member Author

dtzWill commented Oct 7, 2019

You've have specified staging as target branch, even though this rebuilds less than 100 packages. Is that correct?

Good call, switched to master! Thanks!

@dtzWill dtzWill merged commit 58c1198 into NixOS:master Oct 7, 2019
@dtzWill dtzWill deleted the update/setxkbmap-1.3.2 branch October 7, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants