Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdf2psf: 1.192 -> 1.193 #68083

Merged
merged 1 commit into from Sep 4, 2019
Merged

bdf2psf: 1.192 -> 1.193 #68083

merged 1 commit into from Sep 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from rnhmjoj and vrthra September 4, 2019 04:16
@7c6f434c
Copy link
Member

7c6f434c commented Sep 4, 2019

Tested on a VT using https://github.com/7c6f434c/lang-os/blob/master/ttf-to-psf.nix works fine

rnhmjoj
rnhmjoj approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built gohufont and the derivation got the same output hash (should be identical to the bit).

@7c6f434c 7c6f434c merged commit e3fbbb1 into NixOS:master Sep 4, 2019
@c0bw3b c0bw3b mentioned this pull request Oct 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @7c6f434c @rnhmjoj