Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.12 -> 1.13 #68101

Closed
wants to merge 1 commit into from
Closed

go 1.12 -> 1.13 #68101

wants to merge 1 commit into from

Conversation

phifty
Copy link

@phifty phifty commented Sep 4, 2019

Motivation for this change

New version release of Go

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from cstrahan, Mic92 and velovix September 4, 2019 12:30
@Mic92
Copy link
Member

Mic92 commented Sep 4, 2019

@GrahamcOfBorg build direnv

@Mic92
Copy link
Member

Mic92 commented Sep 4, 2019

@GrahamcOfBorg build gogs

@Mic92
Copy link
Member

Mic92 commented Sep 4, 2019 •
edited

Please also set buildGoPackage = buildGo113Package; in all-packages.nix

@rvolosatovs
Copy link
Member

I was just working on the same, haha, but you were faster than me 🏎️
https://github.com/rvolosatovs/nixpkgs/compare/update/go
Regarding @Mic92's comment I suppose you can cherry-pick rvolosatovs@9be54b0

rvolosatovs
rvolosatovs reviewed Sep 4, 2019
View reviewed changes
pkgs/development/compilers/go/1.13.nix

patches = [
./remove-tools-1.11.patch
# ./ssl-cert-file-1.12.1.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSL cert patch missing (rvolosatovs@ebf5d94#diff-1f31e43c115a4b5fac34382fd3cbe504)

@adisbladis
Copy link
Member

adisbladis commented Sep 4, 2019 •
edited

I was working on getting this update in this morning but I have a build failure that I haven't had time to look into yet.

I suggest we incorporate some of the stylistic changes (namely the skipTest function), the SSL patch and the changelog entry from my branch: https://github.com/adisbladis/nixpkgs/tree/go_1_13.

edit: My build failure seems hardware dependent. I cannot reproduce it on my Intel i7-7500U based laptop but can on the AMD Epyc 7401p I attempted the build on first. :S

@adisbladis adisbladis mentioned this pull request Sep 4, 2019
Closed
8 tasks
@phifty
Copy link
Author

phifty commented Sep 4, 2019

I'm quite new in contributing here. No concerns closing this one, since it was a quick fix for me.

@phifty phifty closed this Sep 4, 2019
@adisbladis
Copy link
Member

@phifty I'd rather incorporate those changes on top of your PR :)

@adisbladis adisbladis reopened this Sep 4, 2019
@rvolosatovs rvolosatovs mentioned this pull request Sep 5, 2019
Merged
10 tasks
@adisbladis
Copy link
Member

Superseded by #68135

@adisbladis adisbladis closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs left review comments

@cstrahan cstrahan Awaiting requested review from cstrahan

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@velovix velovix Awaiting requested review from velovix

Assignees
No one assigned
Labels
6.topic: golang 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phifty @Mic92 @rvolosatovs @adisbladis @Janik-Haag