Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.matplotlib: unmark as broken #68102

Merged
merged 1 commit into from Sep 4, 2019
Merged

haskellPackages.matplotlib: unmark as broken #68102

merged 1 commit into from Sep 4, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 4, 2019

Motivation for this change

Wanted to use matplotlib in haskell.
The package is broken because the test are failing. This is due to a runtime dependency on python. I can confirm that the package works fine if python and matplotlib are installed in the environment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested the library is usable
  • Tested compilation of all pkgs that depend on this change using (none)
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@peti peti changed the base branch from master to haskell-updates September 4, 2019 19:01
@peti
Copy link
Member

peti commented Sep 4, 2019

Please target the branch haskell-updates with updates that modify configuration-hackage2nix.yaml. There are automatic re-generation procedures in place that update hackage-packages.nix based on that file, and those processes work on haskell-updates -- not master.

@peti peti merged commit dd7d209 into NixOS:haskell-updates Sep 4, 2019
@rnhmjoj rnhmjoj deleted the matplotlib branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: ruby 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @peti