Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

josm: 15238 -> 15322 #68022

Closed
wants to merge 1 commit into from
Closed

josm: 15238 -> 15322 #68022

wants to merge 1 commit into from

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 3, 2019

Motivation for this change

Changelog (2019-08-26: Stable release 15322)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rycee

@ofborg ofborg bot requested a review from rycee September 3, 2019 19:16
@rycee rycee self-assigned this Sep 3, 2019
rycee pushed a commit that referenced this pull request Sep 3, 2019
@sikmir @rycee
josm: 15238 -> 15322 (#68022)
75a1266
@rycee
Copy link
Member

rycee commented Sep 3, 2019

Thanks! Seems to work well so rebased to master in 75a1266.

@rycee rycee closed this Sep 3, 2019
@sikmir sikmir deleted the josm branch September 4, 2019 06:38
rycee pushed a commit to rycee/nixpkgs that referenced this pull request Oct 23, 2019
@sikmir @rycee
josm: 15238 -> 15322 (NixOS#68022)
17f061b 
(cherry picked from commit 75a1266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees

@rycee rycee

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @rycee