Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpxsee: 7.12 -> 7.13 #68021

Merged
merged 1 commit into from Sep 15, 2019
Merged

gpxsee: 7.12 -> 7.13 #68021

merged 1 commit into from Sep 15, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 3, 2019

Motivation for this change

Changelog:

  • Added support for graph zooming.
  • Several minor bug fixes.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir
Copy link
Member Author

sikmir commented Sep 3, 2019

@GrahamcOfBorg build gpxsee

Copy link
Member

@womfoo womfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Compiled and ran locally on my NixOS x86_64

@bjornfor bjornfor merged commit 57230c1 into NixOS:master Sep 15, 2019
@bjornfor
Copy link
Contributor

Thanks!

@sikmir sikmir deleted the gpxsee branch September 15, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants