Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11: fix for vulkan in >= 435 #68024

Merged
merged 1 commit into from Sep 6, 2019
Merged

nvidia_x11: fix for vulkan in >= 435 #68024

merged 1 commit into from Sep 6, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Sep 3, 2019

Motivation for this change

Fixes #67997, renamed file in the upstream package (and already included patch).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

cpages
cpages approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@cpages cpages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vulkaninfo works for me with this change

@FRidh FRidh merged commit af39568 into NixOS:master Sep 6, 2019
@averelld averelld deleted the nvidia_x11-fix-vulkan branch September 6, 2019 19:20
@ghost ghost mentioned this pull request Sep 9, 2019
Merged
10 tasks
@ambrop72 ambrop72 mentioned this pull request Sep 28, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpages cpages cpages approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvidia_x11: Vulkan functionality is broken in nixos-unstable channel
3 participants
@averelld @cpages @FRidh