weechat: build with python3 by default #68110
Conversation
pkgs/top-level/all-packages.nix
Outdated
| }; | ||
|
|
||
| weechat = wrapWeechat weechat-unwrapped { }; | ||
|
|
||
| weechatScripts = dontRecurseIntoAttrs (callPackage ../applications/networking/irc/weechat/scripts { }); | ||
| weechatScripts = dontRecurseIntoAttrs (callPackage ../applications/networking/irc/weechat/scripts { |
There was a problem hiding this comment.
dontRecurseIntoAttrs is now the default, I think the implementation now is just the id function drv: drv
| weechatScripts = dontRecurseIntoAttrs (callPackage ../applications/networking/irc/weechat/scripts { | |
| weechatScripts = callPackage ../applications/networking/irc/weechat/scripts { |
There was a problem hiding this comment.
yep, had to check
nixpkgs/pkgs/top-level/all-packages.nix
Line 75 in 5e86891
There was a problem hiding this comment.
In fact it's always been the default, dontRecurseIntoAttrs mainly serves a documentation purpose. To quote the comment above the function:
# This is intended to be the reverse of recurseIntoAttrs, as it is
# defined now it exists mainly for documentation purposes, but you
# can also override this with recurseIntoAttrs to recurseInto all
# the Attrs which is useful for testing massive changes. Ideally,
# every package subset not marked with recurseIntoAttrs should be
# marked with this.
There was a problem hiding this comment.
ah, if it has a purpose, then I'm fine with leaving it in :)
|
I agree we should have that at some point. The only thing that concerns me a bit that even archlinux, who were early python3 adopters, build weechat with python2: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/weechat#n13 |
Last time I checked (about a month ago) they were building a lot of applications with python2, but I'm no arch user, so could've been a false impression.
After taking a look at the list, I didn't find any of our currently supported plugins in there. However I guess I should check all of the python stuff manually (just checked |
|
So, short update: rechecked all scripts and it seems as After that we'd need somebody with more darwin experience to fix the build, after that this should be ready IMHO. |
Ma27
force-pushed
the
weechat-python3
branch
from
ec4979d
to
e4619c1
Compare
|
Rebased onto current master, also dropped weechat-xmpp as it relies on pretty old dependencies and appears rather unmaintained atm. |
|
There's also a reference to the weechat-xmpp in aliases |
Ma27
force-pushed
the
weechat-python3
branch
from
e4619c1
to
8d6a47e
Compare
|
Ahh, right, fixed! :) |
Ma27
force-pushed
the
weechat-python3
branch
from
8d6a47e
to
13001b6
Compare
WeeChat also supports Python3 for scripts which should be preferred as CPython2 is about to get EOLed soon: https://weechat.org/scripts/python3/
This plugin is fairly outdated and depends on python2 libraries that don't receive any updates either (xmpppy for instance[1]). [1] https://pypi.org/project/xmpppy/
Ma27
force-pushed
the
weechat-python3
branch
from
13001b6
to
e4bc0e2
Compare
| @@ -380,7 +380,6 @@ mapAliases ({ | |||
| virtviewer = virt-viewer; # added 2015-12-24 | |||
| vorbisTools = vorbis-tools; # added 2016-01-26 | |||
| webkit = webkitgtk; # added 2019-03-05 | |||
| weechat-xmpp = weechatScripts.weechat-xmpp; # added 2018-09-06 | |||
There was a problem hiding this comment.
Maybe?
weechat-xmpp = throw "weechat-xmpp has been removed as it doesn't receive
any updates from upstream and depends on outdated Python2-based modules.";
There was a problem hiding this comment.
Not in favour. Removal already throws an error, and the reason for removal is documented in the release notes.
Motivation for this change
WeeChat also supports Python3 for scripts which should be preferred as
CPython2 is about to get EOLed soon: https://weechat.org/scripts/python3/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @