Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terranix: init at 2.1.1 #68019

Closed
wants to merge 1 commit into from
Closed

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

terranix is a very nixy project and it makes it easier if it is upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import from derivation is not allowed in nixpkgs, so it's not possible to reuse an external nix expression like this. :)

@mrVanDalo
Copy link
Contributor Author

@srhb That is sad, because the package is very nixy. As you can see https://github.com/mrVanDalo/terranix/blob/master/default.nix

I could copy the default.nix into nixpkgs/pkgs/ and use fetchgit when doing import but this is the same thing in green, right?

@srhb
Copy link
Contributor

srhb commented Sep 4, 2019

@mrVanDalo I'm afraid so, yes. Basically, Hydra will refuse to do any IFD. Fetching your repo requires making a derivation (ie. fetchFrom...) so there is no way around it. The Nix must live in nixpkgs.

@mrVanDalo
Copy link
Contributor Author

@srhb So sad :(

I will make myself a ticket. Maybe NUR is the best place for now to make it easy available.
But thanks for the quick response @srhb

@mrVanDalo mrVanDalo closed this Sep 4, 2019
@mrVanDalo mrVanDalo mentioned this pull request Sep 26, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants