ruby_2_3: remove #68030
ruby_2_3: remove #68030
Conversation
|
@Phlogistique @kamilchm would be great if somebody could test sonic-pi in the next couple of days. I do think this is important to get in before 19.09 branches off, though, so I won’t wait indefinitely. |
| @@ -303,8 +303,8 @@ mapAliases ({ | |||
| rssglx = rss-glx; #added 2015-03-25 | |||
| ruby_2_0_0 = throw "deprecated 2018-0213: use a newer version of ruby"; | |||
| ruby_2_1_0 = throw "deprecated 2018-0213: use a newer version of ruby"; | |||
| ruby_2_2_9 = throw "deprecated 2018-0213: use ruby_2_2 instead"; | |||
| ruby_2_3_6 = throw "deprecated 2018-0213: use ruby_2_3 instead"; | |||
There was a problem hiding this comment.
can you also add ruby_2_3 in there?
There was a problem hiding this comment.
I didn’t because we don’t generally do it when removing packages IIRC, and I don’t think aliases.nix should have to contain a list of every attribute to have ever existed.
But it does look like we’ve started here anyway, so I can do, yeah.
There was a problem hiding this comment.
Yeah any removal should be added to this list. And at some point the list will be pruned. This is to allow users that upgrade to get a meaningful error message.
Ruby 2.3 is EOL.
This was added to fix a compiler error in 4bc516a, where it was noted that it still segfaulted after boot. Since it compiles with our default Ruby now, I have to assume that the problem the override was added to set has since been resolved. I don't know how to actually test, however.
This has been EOL since December. We shouldn't still be facilitating its use. Fixes NixOS#67977.
|
Today is 19.09 branch-off day, so if sonic-pi is broken, it’ll have to be fixed as a follow-up. |
This has been EOL since December. We shouldn't still be facilitating its use.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)