Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Quote homepage URLs to follow RFC 0045 #68091

Closed
wants to merge 1 commit into from
Closed

doc: Quote homepage URLs to follow RFC 0045 #68091

wants to merge 1 commit into from

Conversation

mstarzyk
Copy link
Contributor

@mstarzyk mstarzyk commented Sep 4, 2019

Motivation for this change

Unquoted URLs will probably be deprecated with RFC 0045.
This change updates meta.homepage URLs in the documentation to set a better example for nixpkgs contributors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mstarzyk mstarzyk requested a review from FRidh as a code owner September 4, 2019 08:00
@FRidh
Copy link
Member

FRidh commented Sep 4, 2019

The RFC has not been accepted yet and may not either. In case it is accepted, please reopen.

@FRidh FRidh closed this Sep 4, 2019
@mstarzyk
Copy link
Contributor Author

mstarzyk commented Sep 4, 2019

So If I don't mention the RFC, but just say it is about "using quoting consistently in examples" will this pull request be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
2.status: invalid 6.topic: erlang 6.topic: golang 6.topic: ruby 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstarzyk @FRidh