litmus: init at 0.13 #68118
litmus: init at 0.13 #68118
Conversation
|
|
||
| stdenv.mkDerivation rec { | ||
| version = "0.13"; | ||
| name = "litmus-${version}"; |
There was a problem hiding this comment.
Is there any documentation about name vs. pname? I cannot find anything in the documentation.
There was a problem hiding this comment.
Thanks. But when I understand RFC0035 correctly, it only says that name should be automatically set to ${pname}-${version}, if pname and version are set, to reduce redundancy. (But it seems that noone notices the downside of this -- it makes package-definitons less obvious, since then name is "magically" defined and comes out of nowhere. Explicit is better than implicit.)
But RFC0035 does neither require nor recommend to use pname, so the above is perfectly fine.
If "you should use pname instead of name" is the official NixOS-optionion, it should be mentioned in the documentation.
There was a problem hiding this comment.
If "you should use pname instead of name" is the official NixOS-optionion, it should be mentioned in the documentation.
You are right, feel free to open a pull request for the documentation to include it.
There was a problem hiding this comment.
No, I won't and I can't document it.
It's the duty of the ones who want to promote pname to document it, including why and how exactly to use it.
|
|
||
| buildInputs = [ openssl ]; | ||
| configureFlags = [ "--with-ssl" ]; | ||
| installFlags = [ "PREFIX=$(out)" ]; |
There was a problem hiding this comment.
Yes. Without "openssl"/"--with-ssl", litmus would only be able to communicate over http, not https. And https/SSL is important.
inputFlags probably may be omitted, I think.
There was a problem hiding this comment.
(minor correction: do you mean installFlags can be dropped, not inputFlags?)
There was a problem hiding this comment.
Yes, installFlags may be dropped, I think.
There was a problem hiding this comment.
Yes, I was refering to line 14, installFlags.
|
|
||
| buildInputs = [ openssl ]; | ||
| configureFlags = [ "--with-ssl" ]; | ||
| installFlags = [ "PREFIX=$(out)" ]; |
There was a problem hiding this comment.
| installFlags = [ "PREFIX=$(out)" ]; | |
| installFlags = [ "PREFIX=${placeholder "out"}" ]; |
There was a problem hiding this comment.
in this case it doesn't matter, but it's to ensure that you will get the storepath
| name = "litmus-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "http://webdav.org/neon/litmus/${name}.tar.gz"; |
There was a problem hiding this comment.
| url = "http://webdav.org/neon/litmus/${name}.tar.gz"; | |
| url = "http://webdav.org/neon/litmus/${pname}-${version}.tar.gz"; |
|
Thank you for your contributions.
|
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing because review comments are not being fixed. |
Motivation for this change
Add litmus (a WebDAV server comliance tester) to Nix.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @rkoe