Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyvmomi: init at 6.7.1.2018.12 #68109

Merged
merged 1 commit into from Sep 5, 2019
Merged

pythonPackages.pyvmomi: init at 6.7.1.2018.12 #68109

merged 1 commit into from Sep 5, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Sep 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse requested a review from FRidh as a code owner September 4, 2019 15:44
@aanderse
Copy link
Member Author

aanderse commented Sep 4, 2019

@GrahamcOfBorg build python2Packages.pyvmomi python3Packages.pyvmomi

@wd15
Copy link
Contributor

wd15 commented Sep 4, 2019 •
edited

Built for me on Linux 5.0.0-27-generic #28-Ubuntu SMP x86_64 GNU/Linux.

Result of nix-review pr 68109 1

2 packages were built:
  • python27Packages.pyvmomi
  • python37Packages.pyvmomi

@aanderse
Copy link
Member Author

aanderse commented Sep 5, 2019

@peterhoeg @wd15 thanks!

@aanderse aanderse merged commit 636d904 into NixOS:master Sep 5, 2019
@aanderse aanderse deleted the pyvmomi branch September 5, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @wd15 @peterhoeg