Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix-mode
base: ddf091708b90
Choose a base ref
...
head repository: NixOS/nix-mode
compare: 7d681ff81bce
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 4, 2019

  1. Don't freeze full executable paths at load time 

    It's bad practice to use `executable-find` in defcustoms, because the
value will be expanded into a fully-qualified path at the time the
file is loaded, using whatever is the effective `exec-path` at the
time. This can lead to confusion if the file is somehow loaded before
a user deliberately sets up his path.

When only an executable name is used, as is the case with this change,
it is looked up in the $PATH at the time it is used, which reliably
leads to expected behaviour. And the user can of course still
customise any `nix-*-executable` variable to a full path if they wish.
    @purcell
    purcell committed Sep 4, 2019
    Copy the full SHA
    0075080 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #91 from purcell/relative-executable-paths 

    Don't freeze full executable paths at load time
    @matthewbauer
    matthewbauer committed Sep 4, 2019
    Copy the full SHA
    7d681ff View commit details
    Browse the repository at this point in the history