Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python updates: parso, jedi, python-language-server #68112

Merged
merged 3 commits into from Sep 26, 2019
Merged

python updates: parso, jedi, python-language-server #68112

merged 3 commits into from Sep 26, 2019

Conversation

langston-barrett
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@ofborg ofborg bot requested a review from Mic92 September 4, 2019 17:21
@Mic92
Copy link
Member

Mic92 commented Sep 11, 2019

@GrahamcOfBorg build python3.pkgs.python-language-server python2.pkgs.python-language-server

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2019 •
edited

@grahamc did you already noticed that ofborg no longer builds packages?

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@teto
Copy link
Member

teto commented Sep 26, 2019

@GrahamcOfBorg build python3.pkgs.python-language-server python2.pkgs.python-language-server

1 similar comment
@teto
Copy link
Member

teto commented Sep 26, 2019

@GrahamcOfBorg build python3.pkgs.python-language-server python2.pkgs.python-language-server

@teto
Copy link
Member

teto commented Sep 26, 2019

@GrahamcOfBorg build python3.pkgs.python-language-server python2.pkgs.python-language-server

@teto teto merged commit 3d1195f into NixOS:master Sep 26, 2019
@teto
Copy link
Member

teto commented Sep 26, 2019

ty

@langston-barrett langston-barrett deleted the pyls-jedi branch September 26, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@langston-barrett @Mic92 @teto @lheckemann