Don't freeze full executable paths at load time #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's bad practice to use `executable-find` in defcustoms, because the value will be expanded into a fully-qualified path at the time the file is loaded, using whatever is the effective `exec-path` at the time. This can lead to confusion if the file is somehow loaded before a user deliberately sets up his path. When only an executable name is used, as is the case with this change, it is looked up in the $PATH at the time it is used, which reliably leads to expected behaviour. And the user can of course still customise any `nix-*-executable` variable to a full path if they wish.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's bad practice to use
executable-findin defcustoms, because the value will be expanded into a fully-qualified path at the time the file is loaded, using whatever is the effectiveexec-pathat the time. This can lead to confusion if the file is somehow loaded before a user deliberately sets up his path.When only an executable name is used, as is the case with this change, it is looked up in the $PATH at the time it is used, which reliably leads to expected behaviour. And the user can of course still customise any
nix-*-executablevariable to a full path if they wish.