Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Pipelines] avoid parenthesis in job names #17265

Merged
merged 1 commit into from Jun 15, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Jun 11, 2019

The Azure Pipelines integration with GitHub Checks produces checks on
the form "$pipelineName ($jobName)", leading to check names like
"Azure Pipelines (tools/wptrunner/ unittests (macOS))". Use colons as
separator instead, like the existing "wpt.fyi hook" jobs.

Also change some step names for consistency.

The Azure Pipelines integration with GitHub Checks produces checks on
the form "$pipelineName ($jobName)", leading to check names like
"Azure Pipelines (tools/wptrunner/ unittests (macOS))". Use colons as
separator instead, like the existing "wpt.fyi hook" jobs.

Also change some step names for consistency.
@foolip
Copy link
Member Author

foolip commented Jun 11, 2019

@Hexcles @lukebjerring does anything on the wpt.fyi side depend on the job names? I suspect not, right?

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hexcles Hexcles merged commit e758556 into master Jun 15, 2019
@Hexcles Hexcles deleted the foolip/azure-pipelines-job-names branch June 15, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants