Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grab-site: 2.1.15 -> 2.1.16 #62909

Merged
merged 1 commit into from
Jun 9, 2019
Merged

grab-site: 2.1.15 -> 2.1.16 #62909

merged 1 commit into from
Jun 9, 2019
+2 −2

Conversation

ivan
Copy link
Member

@ivan ivan commented Jun 9, 2019

Motivation for this change

This release fixes an issue with initial URLs being retried forever on failure:

https://github.com/ArchiveTeam/grab-site/commits/master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ivan
Copy link
Member Author

ivan commented Jun 9, 2019

@GrahamcOfBorg build grab-site

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 9, 2019
@ivan
Copy link
Member Author

ivan commented Jun 9, 2019

Please merge

@Ma27
Copy link
Member

Ma27 commented Jun 9, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 1e0cd8a into NixOS:master Jun 9, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 9, 2019

@ivan thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @Ma27