Don't show |cursor: pointer| on unclickable <area>s #17267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2019
The HTML spec says: "The href attribute on a and area elements is not required; when those elements do not have href attributes they do not create hyperlinks." Background: Chrome already excludes unclickable <area>s, <area>s without a href attribute, from the tab order. Problem: Unclickable <area>s still show a "click me" hint. Solution: Mimick Firefox. Only show the pointer for actual <area> links. Note: Found during crrev.com/c/1632231. We don't want unclickable <area>s to act navigable. Bug: 972556 Change-Id: I9214171290659b8b800db3e462478e2a1327c832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653009 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#668409}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1653009
branch
from
137c6ca
to
29d135f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML spec says:
"The href attribute on a and area elements is not
required; when those elements do not have href
attributes they do not create hyperlinks."
Background:
Chrome already excludes unclickable <area>s, <area>s
without a href attribute, from the tab order.
Problem:
Unclickable <area>s still show a "click me" hint.
Solution:
Mimick Firefox. Only show the pointer for actual
<area> links.
Note:
Found during crrev.com/c/1632231. We don't want
unclickable <area>s to act navigable.
Bug: 972556
Change-Id: I9214171290659b8b800db3e462478e2a1327c832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653009
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#668409}