Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvm2: 2.03.01 -> 2.03.03 #62942

Closed
wants to merge 2 commits into from
Closed

lvm2: 2.03.01 -> 2.03.03 #62942

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 10, 2019

Motivation for this change

May still be a pre-release? Can't find that reference now but FYI.

https://sourceware.org/git/?p=lvm2.git;a=tag;h=refs/tags/v2_03_03
https://sourceware.org/git/?p=lvm2.git;a=tag;h=refs/tags/v2_03_02

Testing and review, please!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c June 10, 2019 12:07
@dtzWill
Copy link
Member Author

dtzWill commented Jun 12, 2019

Ha, well I can't mark these as requested/required changes that need to be addressed, but improvements I've noticed after using this for a bit:

  • systemd-run mention in one of the udev rules needs some working so that it works properly. Hopefully this is staightforward to someone more familiar with these--and only a bit longer for anyone else. Not sure if can be considered a "builtin" or... really what assumptions an be made.
  • 2.03.04 has been released, so might as well bump to that while upgrading this! :)

@dtzWill
Copy link
Member Author

dtzWill commented Nov 16, 2019

Closing until have bandwidth to tackle properly, no hard feelings :).

@dtzWill dtzWill closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dtzWill