Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 80971ab7923d
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: da8d885ea817
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 10, 2019

  1. python3Packages.nltk: 3.4 -> 3.4.3

    @dtzWill @FRidh
    dtzWill authored and FRidh committed Jun 10, 2019
    Copy the full SHA
    da8d885 View commit details
Showing with 2 additions and 11 deletions.
  1. +2 −11 pkgs/development/python-modules/nltk/default.nix
13 changes: 2 additions & 11 deletions pkgs/development/python-modules/nltk/default.nix
View file
Original file line number Diff line number Diff line change
@@ -1,26 +1,17 @@
{ fetchPypi, buildPythonPackage, lib, six, singledispatch, isPy3k, fetchpatch }:

buildPythonPackage rec {
version = "3.4";
version = "3.4.3";
pname = "nltk";

src = fetchPypi {
inherit pname version;
extension = "zip";
sha256 = "286f6797204ffdb52525a1d21ec0a221ec68b8e3fa4f2d25f412ac8e63c70e8d";
sha256 = "1cjkv4jmmlr0w4qi399ncgb6lp41mb9i352934288wh9xad15mqj";
};

propagatedBuildInputs = [ six ] ++ lib.optional (!isPy3k) singledispatch;

# TODO: remove patch during update to new version
patches = [
(fetchpatch {
url = https://github.com/nltk/nltk/commit/3966111cbf2f35fb86082b2f12acd90d75e9b8bb.patch;
includes = [ "setup.py" ];
sha256 = "1sxafnvf6nzv6d996xc1rys06x62s36swgpfqhsyh6l1lj7y38jw";
})
];

# Tests require some data, the downloading of which is impure. It would
# probably make sense to make the data another derivation, but then feeding
# that into the tests (given that we need nltk itself to download the data,