Add ahem.css to many more tests #17292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
astearns,
birtles,
cbiesinger,
dbaron,
dirkschulze,
drott,
fantasai,
frivoal,
javifernandez and
kojiishi
wpt-pr-bot
requested review from
litherum,
mrego,
nox,
plinss,
r12a,
rachelandrew,
svgeesus,
svillar,
tabatkins and
upsuper
and removed request for
astearns,
cbiesinger,
javifernandez,
plinss and
r12a
|
Looks like the only new failures in this PR are the following: All of these are non-reftests, and they probably need The remainder of the failures in this PR are already covered in #17205. |
|
53e692f added that to those tests, but it seems like that didn't suffice, bleh. |
|
OK, I've removed all the tests changed in #17205 from this PR now, and hopefully fixed the rest. |
This was: LANG=C grep -R -l -i 'font.*:.*ahem' css | xargs grep -L ahem\\.css | xargs gsed -i 's/\(^.*\)<style/\1<link rel=\"stylesheet\" type=\"text\/css\" href=\"\/fonts\/ahem.css\" \/>\n\1<style/g' Then edited to wait for document.fonts.ready in testharness.js tests
This is: rg --files-with-matches 'grid-descendants.css' css/css-grid/abspos/ | xargs grep -L ahem.css | xargs gsed -i'' -e 's/\(^.*\)\(<.*grid-descendants.css\)/\1<link rel=\"stylesheet\" href=\"\/fonts\/ahem.css\">\n\1\2/g'
|
Okay, no regressions in Safari/Firefox/Chrome, so rebased and cleaned up history so we can land this! |
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
Add ahem.css to many more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #17291, and following on from #17173. Will probably need regressions split out, as in #17205.
cc/ @LukeZielinski