New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mptcp tools #62981
Mptcp tools #62981
Conversation
pkgs/top-level/all-packages.nix
Outdated
@@ -15685,6 +15687,9 @@ in | |||
nettools = if stdenv.isLinux then callPackage ../os-specific/linux/net-tools { } | |||
else unixtools.nettools; | |||
|
|||
nettools_mptcp = if stdenv.isLinux then callPackage ../os-specific/linux/net-tools/mptcp.nix { } | |||
else unixtools.nettools; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes little sense as you would rather see nettols_mptcp fail than installing unixtools.nettools without warnings. This is a good fallback for nettols
but not for nettols_mptcp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the if.
I've bumped the versions for mptcp 0.95. The CI errors are strange though ? |
The CI errors are strange, but not as much as the build errors I get on 127df2799ba you just force pushed.
|
With the above change, I could test everything. Seems fine. |
Adds an -m flag to track MPTCP connection.
allows to disable MPTCP on specific interfaces.
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Motivation for this change
One of the pain point of MPTCP is - because it's not upstream yet - it's kinda hard to configure as standard tools may need to be overriden with their MPTCP fork.
Nix makes it easier.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)