StyleResolverState may not be constructed with a null element. #17268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645292
branch
from
051a0e7
to
1f5c929
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645292
branch
from
1f5c929
to
3c5e71f
Compare
It is dereferenced in ElementContext. Even documentElement() may sometimes be null. With this CL, StyleResolverState and ElementContext are always associated with a non-null Element. In the case where we used to pass a Document for ElementContext, or documentElement() directly, we will now pass documentElement() if not null or avoid using StyleResolverState if it is null. Bug: 971035 Change-Id: If7f34556f68aa8b55f157b2fbad5c0a331869e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645292 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668127}
foolip
force-pushed
the
chromium-export-cl-1645292
branch
from
3c5e71f
to
9ffc0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is dereferenced in ElementContext. Even documentElement() may
sometimes be null. With this CL, StyleResolverState and ElementContext
are always associated with a non-null Element.
In the case where we used to pass a Document for ElementContext, or
documentElement() directly, we will now pass documentElement() if not
null or avoid using StyleResolverState if it is null.
Bug: 971035
Change-Id: If7f34556f68aa8b55f157b2fbad5c0a331869e28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645292
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668127}