Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-generate-config: add size attribute for swap *files* #62963

Closed
wants to merge 1 commit into from
Closed

nixos-generate-config: add size attribute for swap *files* #62963

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Jun 10, 2019 •
edited

Motivation for this change

Up until now, the output has been the same for swap devices and swap
files:

{ device = "/var/swapfile"; }

Whereas for swap files it's more correct to output the size as well,
which is what this change does:

{ device = "/var/swapfile"; size = 8192; }

(The size attribute can be changed and NixOS will update the underlying
swap file size.)

Another option is to not output anything for swap files, since they
can be handled completely declaratively in configuration.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bjornfor
nixos-generate-config: add size attribute for swap *files*
4d38e69 
Up until now, the output has been the same for swap devices and swap
files:

  { device = "/var/swapfile"; }

Whereas for swap *files* it's more correct to output the size as well,
which is what this change does:

  { device = "/var/swapfile"; size = 8192; }

(The size attribute can be changed and NixOS will update the underlying
swap file size.)

Another option is to not output anything for swap *files*, since they
can be handled completely declaratively in configuration.nix.
@bjornfor bjornfor force-pushed the nixos-generate-config-swapfile branch from 2267d23 to 4d38e69 Compare June 10, 2019 18:45
@bjornfor
Copy link
Contributor Author

Another option is to not output anything for swap files, since they
can be handled completely declaratively in configuration.nix.

I think I actually would prefer this option. Any comments?

@edolstra
Copy link
Member

Yes, it sounds better to put them in configuration.nix.

@bjornfor
Copy link
Contributor Author

Closing in favor of #63083.

@bjornfor bjornfor closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjornfor @edolstra