-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply some ReSharper fixes to our code #2199
Conversation
ksp_plugin_adapter/main_window.cs
Outdated
@@ -367,13 +364,13 @@ internal class MainWindow : SupervisedWindowRenderer { | |||
value : must_record_journal_, | |||
text : "Record journal (starts on load)"); | |||
UnityEngine.GUILayout.Label( | |||
"Journalling is " + (journaling_ ? "ON" : "OFF"), | |||
"Journalling is " + (journalling_ ? "ON" : "OFF"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the spelling of the variable was good and that the string should be changed instead: https://www.lexico.com/en/definition/journal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
var value_if_boxed = managed_object as T?; | ||
if (value_if_boxed != null) { | ||
value = value_if_boxed.Value; | ||
if (managed_object is T value_if_boxed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it does that with a single click. I didn't even know that this existed.
Two types of changes:
using
clauses).No contentious things like adjusting naming conventions or reformatting.