Python modules/robotframework sshlibrary #62943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase instead of using a merge. |
worldofpeace
suggested changes
Jun 14, 2019
There was a problem hiding this comment.
Looks good, some comments.
Also, please correct your commit msg to match the contribution guidelines
pythonPackages.robotframework-sshlibrary: init at 3.3.0
| sha256 = "fc5b5db63cf63a937bd4ada1a8b7508ec8a75d9454fa75e6410cbe72fd718de9"; | ||
| }; | ||
|
|
||
| # buildInputs = [ unittest2 ]; |
There was a problem hiding this comment.
Suggested change
| # buildInputs = [ unittest2 ]; |
| { stdenv | ||
| , buildPythonPackage | ||
| , fetchPypi | ||
| # , unittest2 |
There was a problem hiding this comment.
Suggested change
| # , unittest2 |
| }; | ||
|
|
||
| # buildInputs = [ unittest2 ]; | ||
| propagatedBuildInputs = [ robotframework paramiko scp ]; |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = [ robotframework paramiko scp ]; | |
| # unit tests are impure | |
| doCheck = false; | |
| propagatedBuildInputs = [ robotframework paramiko scp ]; |
talkara
force-pushed
the
python-modules/robotframework-sshlibrary
branch
from
ba0fcc7
to
ce0197f
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)