Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: Remove deprecated flag from rndc-confgen #62972

Closed
wants to merge 1 commit into from
Closed

bind: Remove deprecated flag from rndc-confgen #62972

wants to merge 1 commit into from

Conversation

m1cr0man
Copy link
Contributor

Fixes bind.service startup issue after #61619

Motivation for this change

The bind service won't start on current unstable channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@m1cr0man
bind: Remove deprecated flag from rndc-confgen
a77d2d6 
Fixes bind.service startup issue after NixOS#61619
@matthewbauer
Copy link
Member

I think this can go straight to master

@vcunat
Copy link
Member

vcunat commented Jun 11, 2019

Hmm, this incompatibility wasn't mentioned in the announcement. In any case, I see no use waiting with this, so it's in master: 24e974b. Thanks! I confirmed the bind test is fixed by this.

@vcunat vcunat closed this Jun 11, 2019
@m1cr0man m1cr0man deleted the staging branch October 18, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m1cr0man @matthewbauer @vcunat @Janik-Haag