FuzzyMatching works #2937
Merged
FuzzyMatching works #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Jun 12, 2019
tests/flakes.sh
Outdated
| (! nix build -o $TEST_ROOT/result --flake-registry $registry flake4/removeXyzzy:xyzzy) | ||
|
|
||
| # Test whether fuzzy-matching works for IsGit | ||
| (! nix build -o $TEST_ROOT/result --flake-registry $registry file://$flake4Dir/removeXyzzy:xyzzy) |
There was a problem hiding this comment.
It's probably a good idea to also have a positive test for flake4/removeXyzzy, e.g. nix build flake4/removeXyzzy:sth.
edolstra
reviewed
Jun 18, 2019
tests/config.nix
Outdated
| PATH = path; | ||
| } // removeAttrs args ["builder" "meta"]) | ||
| // { meta = args.meta or {}; }; | ||
| } |
There was a problem hiding this comment.
I guess you accidentally added this file, can you remove it from the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2843