Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-whatsapp: 2019-02-24 -> 2019-07-04 #62911

Merged
merged 1 commit into from Jul 12, 2019
Merged

mautrix-whatsapp: 2019-02-24 -> 2019-07-04 #62911

merged 1 commit into from Jul 12, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 9, 2019 •
edited

Motivation for this change

Bump to the latest revision of mautrix-whatsapp to regain
compatibility with matrix-synapse 0.99.5.

Please note that it was necessary to alter some of the sources in
deps.nix, please read the comment at the top of the file for further
information.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 9, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jun 9, 2019

The current version of mautrix-whatsapp on master breaks in my synapse setup (0.99.5 from release-19.03), so this should be backported as well.

@Ma27
Copy link
Member Author

Ma27 commented Jun 15, 2019

Using this patch on my Matrix HS for about one week. Unless there are any further objections, I'd merge this in a week :)

@Ma27 Ma27 changed the title mautrix-whatsapp: 2019-02-24 -> 2019-06-01 WIP mautrix-whatsapp: 2019-02-24 -> 2019-06-01 Jun 26, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jun 26, 2019

Marking this as WIP as I'm also facing the following issues atm:

It seems as it took some more time on my HS to encounter those issues, but I currently need to restart the service regularly. I'll wait for an upstream patch and apply it onto this branch, then this should be mergeable.

@Ma27
mautrix-whatsapp: 2019-02-24 -> 2019-07-04
b86a3e4 
Bump to the latest revision of `mautrix-whatsapp` to regain
compatibility with matrix-synapse 0.99.5.

Please note that it was necessary to alter some of the sources in
`deps.nix`, please read the comment at the top of the file for further
information.
@Ma27 Ma27 changed the title WIP mautrix-whatsapp: 2019-02-24 -> 2019-06-01 mautrix-whatsapp: 2019-02-24 -> 2019-07-04 Jul 10, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jul 10, 2019

Just updated to the latest version available after having problems with the current version (most likely due to api changes in whatsapp web). My setup appears to work fine now, I'd wait for some time now, but after that this should be mergable IMHO.

@Ma27
Copy link
Member Author

Ma27 commented Jul 12, 2019

Okay, after thinking a little bit about this, I guess that merging and backporting this for now is fine due to the following reasons:

  • The current version in master (2019-02-24) is not compatible anymore with matrix-synapse 0.99.5 (the version I'm currently using in production) and matrix-synapse 1.x (which was the original reason why I filed this PR)
  • It seems as WhatsApp Web changed some parts in their API as I had a hard time connecting (and recreating the login) last week (before I updated the commit). The current mautrix-whatsapp version appears to work fine as they've bumped to a new go-whatsapp version: mautrix/whatsapp@45e60c2

Unfortunately there's still a pending issue with buffer overflows (that occurred to me twice in June and could be fixed with a restart, since the last bump on this branch I didn't encounter that problem enymore): mautrix/whatsapp#74

Despite this issue I decided to merge this now as this fixes several problems in the bridge and is therefore a step towards the proper direction. As I depend on WhatsApp pretty much at the moment it's pretty likely that I'll notice in case further problems arise and I'd do my best to work around this then :)

Regarding the go2nix resolve problems (the reason why I had to manually patch deps.nix): I'm not entirely sure what's the actual cause for this, when I have more time, I'll do some more debugging (and probably we can use a different approach which actually supports replace expressions).

@Ma27 Ma27 merged commit b279443 into NixOS:master Jul 12, 2019
@Ma27 Ma27 deleted the bump-mautrix-whatsapp branch July 12, 2019 16:18
@Ma27
Copy link
Member Author

Ma27 commented Jul 12, 2019

Backported as 5f707e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ma27