Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waybar: 0.6.7 -> 0.7.0 #62947

Merged
merged 4 commits into from Jun 23, 2019
Merged

waybar: 0.6.7 -> 0.7.0 #62947

merged 4 commits into from Jun 23, 2019

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Jun 10, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9 Synthetica9 changed the title Waybar068 waybar: 0.6.7 -> 0.6.8 Jun 10, 2019
@minijackson
Copy link
Member

Waybar 0.6.9 released a couple of hours ago, could you update your PR? ^^

@Synthetica9
Copy link
Member Author

@minijackson Done!

@minijackson
Copy link
Member

Well, Waybar 0.7.0 released just now, could you update your PR again?

Sorry the PR is taking this long, I haven't got the rights to merge it, but for what it's worth, I approve the changes ^^

@Synthetica9 Synthetica9 changed the title waybar: 0.6.7 -> 0.6.8 waybar: 0.6.7 -> 0.7.0 Jun 23, 2019
@Mic92 Mic92 merged commit 508d802 into NixOS:master Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @minijackson @Mic92