Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8f2a77e1de8b
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 32b374f78060
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on May 31, 2019

  1. nixos/pulseaudio: Set speex-float-5 as default resample-method 

    The upstream default (speex-float-1) results in audible artifacts
    @adisbladis
    adisbladis committed May 31, 2019
    Copy the full SHA
    b19e838 View commit details

Commits on Jun 6, 2019

  1. rl-1909: add note about PulseAudio resample-method

    @worldofpeace
    worldofpeace committed Jun 6, 2019
    Copy the full SHA
    29cc54c View commit details

Commits on Jun 10, 2019

  1. Merge pull request #62315 from adisbladis/pulseaudio/resample-method 

    nixos/pulseaudio: Set speex-float-5 as default resample-method
    @adisbladis
    adisbladis authored Jun 10, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    32b374f View commit details
Showing with 10 additions and 0 deletions.
  1. +7 −0 nixos/doc/manual/release-notes/rl-1909.xml
  2. +3 −0 nixos/modules/config/pulseaudio.nix
7 changes: 7 additions & 0 deletions nixos/doc/manual/release-notes/rl-1909.xml
View file
Original file line number Diff line number Diff line change
@@ -229,6 +229,13 @@
<literal>buildRustPackage</literal> may have to be updated as well.
</para>
</listitem>
<listitem>
<para>
The default resample-method for PulseAudio has been changed from the upstream default <literal>speex-float-1</literal>
to <literal>speex-float-5</literal>. Be aware that low-powered ARM-based and MIPS-based boards will struggle with this
so you'll need to set <option>hardware.pulseaudio.daemon.config.resample-method</option> back to <literal>speex-float-1</literal>.
</para>
</listitem>
</itemizedlist>
</section>
</section>
3 changes: 3 additions & 0 deletions nixos/modules/config/pulseaudio.nix
View file
Original file line number Diff line number Diff line change
@@ -245,6 +245,9 @@ in {
# Disable flat volumes to enable relative ones
hardware.pulseaudio.daemon.config.flat-volumes = mkDefault "no";

# Upstream defaults to speex-float-1 which results in audible artifacts
hardware.pulseaudio.daemon.config.resample-method = mkDefault "speex-float-5";

# Allow PulseAudio to get realtime priority using rtkit.
security.rtkit.enable = true;