Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xvfb_run: fix hash #62926

Merged
merged 3 commits into from Jul 29, 2019
Merged

xvfb_run: fix hash #62926

merged 3 commits into from Jul 29, 2019

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jun 10, 2019

Motivation for this change

While trying to upgrade from 18.09 to 19.03 locally, I had to override the xvfb_run hash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@yurrriq yurrriq marked this pull request as ready for review June 10, 2019 10:17
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@worldofpeace worldofpeace merged commit ff04067 into NixOS:master Jul 29, 2019
@kvtb
Copy link
Contributor

kvtb commented Jul 13, 2021

@kvtb
Copy link
Contributor

kvtb commented Jul 13, 2021

@kvtb kvtb mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants