Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs: 0.4.20 -> 0.4.21 (module, drop deps.nix) #62917

Merged
merged 1 commit into from Jun 11, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jun 11, 2019

Should be good now, thanks!

@ofborg ofborg bot requested a review from fpletz June 11, 2019 12:04
@fpletz fpletz merged commit 6bd90a3 into NixOS:master Jun 11, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

Getting a build error for modules here.

go: finding github.com/go-toolsmith/astcast v0.0.0-20181028201508-b7a89ed70af1
go: error loading module requirements
builder for '/nix/store/00qvnbnjd2w86jpqvgj79gzxji6swjy2-ipfs-0.4.21-go-modules.drv' failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants