Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme-tiny: 2016-03-26 -> 4.0.4 #62931

Merged
merged 1 commit into from Jun 10, 2019
Merged

acme-tiny: 2016-03-26 -> 4.0.4 #62931

merged 1 commit into from Jun 10, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 10, 2019

Motivation for this change
  • fetch from pypi
  • nearly fix tests,
    but they seem to hang so leaving disabled for now
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Have not tried actually using this script, sorry.

@dtzWill
acme-tiny: 2016-03-26 -> 4.0.4
ea18bea 
* fetch from pypi
* nearly fix tests,
  but they seem to hang so leaving disabled for now
@dtzWill dtzWill requested a review from FRidh as a code owner June 10, 2019 03:20
mmahut
mmahut approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@fpletz fpletz merged commit 567a05f into NixOS:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mmahut @fpletz