Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.3.2 -> 0.3.3 #62916

Merged
merged 1 commit into from Jun 16, 2019
Merged

alacritty: 0.3.2 -> 0.3.3 #62916

merged 1 commit into from Jun 16, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 10, 2019 •
edited

Motivation for this change

Update alacritty to the latest release.
https://github.com/jwilm/alacritty/releases/tag/v0.3.3
https://github.com/jwilm/alacritty/blob/v0.3.3/CHANGELOG.md

Note:
CHANGELOG.md: The xclip dependency has been removed

cc @Mic92 to review. Thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 June 10, 2019 03:00
mmahut
mmahut approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@xrelkd xrelkd changed the title alacritty: 0.3.2 -> 0.3.3-rc1 alacritty: 0.3.2 -> 0.3.3-rc2 Jun 16, 2019
@xrelkd xrelkd changed the title alacritty: 0.3.2 -> 0.3.3-rc2 alacritty: 0.3.2 -> 0.3.3 Jun 16, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 16, 2019

@marsam Could you review this PR, if possible?
Thank you very much!

@marsam
Copy link
Contributor

marsam commented Jun 16, 2019

@GrahamcOfBorg build alacritty

@marsam marsam merged commit bb81bec into NixOS:master Jun 16, 2019
@marsam
Copy link
Contributor

marsam commented Jun 16, 2019

built and tested locally on NixOS and Darwin
Thanks!

@xrelkd xrelkd deleted the update/alacritty branch June 17, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @marsam @mmahut